From 7a9b19f72a5e689ee21a93e80b160095d96549ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iwo=20Strzebo=C5=84ski?= Date: Thu, 15 Oct 2026 21:46:04 +0000 Subject: [PATCH] Put the vt_tray note in $comment, not in properties The note added a moment ago sat inside `properties` as `"_comment_no_vt_tray": "..."`, which declares a property whose schema is a string - and in draft 2020-12 a subschema has to be an object or a boolean. It parses as JSON and reads fine, and a strict validator would reject the whole schema. `$comment` is the keyword for this and belongs beside `properties` rather than inside it. Swept the rest of schemas/ for the same shape while here: every other property value is a real subschema. --- schemas/bambulab/v2/report/print/push_status.schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schemas/bambulab/v2/report/print/push_status.schema.json b/schemas/bambulab/v2/report/print/push_status.schema.json index edf765f..0b9238d 100644 --- a/schemas/bambulab/v2/report/print/push_status.schema.json +++ b/schemas/bambulab/v2/report/print/push_status.schema.json @@ -7,10 +7,10 @@ { "$ref": "../../../common/envelope.schema.json" }, { "type": "object", + "$comment": "There is deliberately no vt_tray property here. A real v2 printer omits the key entirely rather than sending an empty object, confirmed live, so absence means 'not reported' and not 'no external spool' - do not add it to make this symmetrical with v1. It is why the external-spool count cannot be derived from a report: counting reported spools would give 0 on exactly the dual-nozzle H2C that has two (see common/ams/ams_mapping.schema.json).", "properties": { "command": { "const": "push_status" }, - "_comment_no_vt_tray": "There is deliberately no vt_tray here. A real v2 printer omits the key entirely rather than sending an empty object, confirmed live, so absence means 'not reported' and not 'no external spool' - do not add it to make this symmetrical with v1. It is why the external-spool count cannot be derived from a report: counting reported spools would give 0 on exactly the dual-nozzle H2C that has two (see common/ams/ams_mapping.schema.json).", "2D": { "$ref": "./_2d_report.schema.json" }, "3D": { "$ref": "./_3d_report.schema.json" },