Fix broken $refs from the bambulab schema underscore-rename, remove stale v2/
- print.schema.json, _ams.schema.json, _ams_unit.schema.json still pointed at the pre-rename filenames (ams.schema.json, ams_unit.schema.json, ams_tray.schema.json) after the underscore-prefix split - fixed all three, verified with a full jsonschema + referencing validation run against real captures (get_version, pushall, a full print/ams/xcam report with both empty and loaded trays) plus negative tests. - _upgrade_state.schema.json: fixed its $id (pointed at report/info/, file lives under report/print/) and its title (said "ModuleInfo", clearly copy-pasted from _module_info.schema.json). Wired it into print.schema.json as the print report's `upgrade_state` property - the file existed but nothing referenced it yet. - Deleted schemas/bambulab/v2/, which had been recreated as stale, broken copies of an older v1 (missing the envelope allOf, missing the underscore renames, $ids still pointing at v1/ paths) - the repo's own README documents v2 as intentionally removed until V2's wire format is known to differ from V1's. - Updated schemas/bambulab/README.md's layout tree and inheritance- example reference, both stale after the underscore rename. - Removed stray tsc -b build output (packages/ts-types/src/*.d.ts/js) that isn't meant to be committed (outDir is dist/, gitignored). Verified: cargo check clean (continuum-proxy, continuum-ai-worker, rust-types), tsc clean (continuum-backend, continuum-common ts-core), 10/10 JSON Schema validation cases passing.
This commit is contained in:
@@ -8,18 +8,18 @@ pub use continuum::v1::{
|
||||
MaterialProfile, PrintJob, PrintJobStatus, PrintParameters, Template,
|
||||
};
|
||||
|
||||
// Bambu's raw MQTT command/report structs are NOT modeled here — they're
|
||||
// Bambu's raw MQTT command/report structs are NOT modeled here - they're
|
||||
// plain hand-written Rust + serde in continuum-proxy's
|
||||
// src/printer/bambu_commands/, not proto. That data is JSON-over-MQTT
|
||||
// (not binary protobuf), and only continuum-proxy ever needs to parse it
|
||||
// — none of protobuf's actual value (cross-language codegen, binary wire
|
||||
// - none of protobuf's actual value (cross-language codegen, binary wire
|
||||
// efficiency) applies, and forcing it through prost-build's codegen model
|
||||
// anyway produced real, avoidable friction (see this crate's git history
|
||||
// for the specifics: a field/variant attribute-matching collision on
|
||||
// `oneof`, needing package-scoped `type_attribute` calls, explicit
|
||||
// `field_attribute(..., "#[serde(default)]")` for fields that aren't
|
||||
// always present — every one of these disappears with a hand-written
|
||||
// always present - every one of these disappears with a hand-written
|
||||
// struct, where `Option<T>` and `#[serde(flatten)]` just work with zero
|
||||
// configuration). Proto stays for continuum.v1 above, which — unlike
|
||||
// this — is a schema we designed ourselves and that both TS and Rust
|
||||
// configuration). Proto stays for continuum.v1 above, which - unlike
|
||||
// this - is a schema we designed ourselves and that both TS and Rust
|
||||
// genuinely need.
|
||||
|
||||
Reference in New Issue
Block a user