From 34c7c97d4f83cf46ef5641d878e486f4eda87852 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iwo=20Strzebo=C5=84ski?= Date: Fri, 28 Aug 2026 18:36:23 +0000 Subject: [PATCH] Fix real codegen bugs: unused proto import, missing runtime deps, no barrel index protoc warned that print_job.proto imported template.proto without using it - removed. ts-types/package.json was missing protobufjs and long, which the ts-proto-generated code imports at runtime - tsc failed with 'cannot find module'. src/index.ts also re-exports './generated' as a namespace, but ts-proto wasn't configured to emit an index barrel file for it - added outputIndex=true to the protoc invocation. Verified with a clean 'bun run build' (both TS and Rust codegen) and 'tsc -b'. --- .gitignore | 4 ++++ package.json | 2 +- packages/ts-types/package.json | 4 +++- proto/continuum/v1/print_job.proto | 2 -- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index 88eaf6d..ab07540 100644 --- a/.gitignore +++ b/.gitignore @@ -3,6 +3,10 @@ dist/ target/ *.log .env +bun.lockb +bun.lock +Cargo.lock +*.tsbuildinfo packages/ts-types/src/generated/* !packages/ts-types/src/generated/.gitkeep diff --git a/package.json b/package.json index e1dfa06..df795c8 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,7 @@ "packages/*" ], "scripts": { - "build:ts": "protoc --plugin=protoc-gen-ts_proto=./node_modules/.bin/protoc-gen-ts_proto --ts_proto_out=packages/ts-types/src/generated --ts_proto_opt=esModuleInterop=true,outputServices=false,useOptionals=messages -I proto $(find proto -name '*.proto')", + "build:ts": "protoc --plugin=protoc-gen-ts_proto=./node_modules/.bin/protoc-gen-ts_proto --ts_proto_out=packages/ts-types/src/generated --ts_proto_opt=esModuleInterop=true,outputServices=false,useOptionals=messages,outputIndex=true -I proto $(find proto -name '*.proto')", "build:rust": "cargo build -p continuum-rust-types --manifest-path packages/rust-types/Cargo.toml", "build": "npm run build:ts && npm run build:rust", "typecheck": "tsc -b" diff --git a/packages/ts-types/package.json b/packages/ts-types/package.json index 9375436..dc2d641 100644 --- a/packages/ts-types/package.json +++ b/packages/ts-types/package.json @@ -9,6 +9,8 @@ ".": "./src/index.ts" }, "dependencies": { - "@sinclair/typebox": "^0.32.0" + "@sinclair/typebox": "^0.32.0", + "protobufjs": "^7.4.0", + "long": "^5.2.3" } } diff --git a/proto/continuum/v1/print_job.proto b/proto/continuum/v1/print_job.proto index 1b08357..0659602 100644 --- a/proto/continuum/v1/print_job.proto +++ b/proto/continuum/v1/print_job.proto @@ -2,8 +2,6 @@ syntax = "proto3"; package continuum.v1; -import "continuum/v1/template.proto"; - enum PrintJobStatus { PRINT_JOB_STATUS_UNSPECIFIED = 0; PRINT_JOB_STATUS_QUEUED = 1;