octoturge
13bfec97fe
Down from 29 warnings to 2, in the spirit of 4ab95ff.
The doc warnings were all one mistake made repeatedly: a paragraph wrapped so
that a line *began* with `- ` or `+ `, which rustdoc reads as a markdown list
marker and the following lines as unindented continuations. The prose always
meant an em-dash. Fixed by moving the dash to the end of the previous line and
re-wrapping; not one word changed, which is the point - these comments record
things confirmed against real printers and are worth more than the warning.
The genuine lists just had their continuations de-indented and stayed lists.
The code ones are `match x { V(v) => .., _ => {} }` to `if let`, and nested
`if let Some(x) = .. { if cond { .. } }` to a let-chain. None had an `else`,
so each is the same control flow written once instead of twice.
Two warnings are left deliberately, because fixing them is not cosmetic:
`AmsTray` (544 bytes against 32) and `BambuReport` (984 against 120) both have
one variant far larger than the rest. The fix clippy wants is a `Box`, which
changes how every reader of those enums is written and puts an allocation on
the push_status path that currently has none. Worth measuring before doing,
not worth doing to silence a warning.
51 tests still pass.
30 lines
953 B
Rust
30 lines
953 B
Rust
//! Run with: cargo run --example test_bambu_certs
|
|
//!
|
|
//! Loads printers.toml (copy printers.example.toml to get started, fill in
|
|
//! your real printers) and attempts a raw TLS handshake to each Bambu
|
|
//! printer's MQTTS port (8883) - no MQTT protocol involved, just "does the
|
|
//! certificate verify". Prusa/Klipper entries are skipped; they don't have
|
|
//! this trust question.
|
|
|
|
use continuum_proxy::fleet;
|
|
use continuum_proxy::printer::PrinterHandle;
|
|
|
|
fn main() -> anyhow::Result<()> {
|
|
let printers = fleet::load(std::path::Path::new("printers.toml"))?;
|
|
|
|
for printer in &printers {
|
|
if let PrinterHandle::Bambu(bambu) = printer {
|
|
report(bambu.base().name.as_str(), bambu.test_tls_handshake())
|
|
}
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
fn report(name: &str, result: anyhow::Result<()>) {
|
|
match result {
|
|
Ok(()) => println!("{name}: OK - certificate verified"),
|
|
Err(err) => println!("{name}: FAILED - {err}"),
|
|
}
|
|
}
|